Make sydent.threepid pass mypy --strict #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2021 18:07
DMRobertson
force-pushed
the
dmr/mypy-threepid
branch
2 times, most recently
from
c2dca4d to
f5f785e
Compare
|
Oops, I confused my branches. |
reivilibre
requested changes
Oct 19, 2021
sydent/threepid/bind.py
Outdated
Comment on lines
97
to
102
| token["signed"] = { | ||
| "mxid": mxid, | ||
| "token": cast(str, token["token"]), | ||
| } | ||
| token["signed"] = signedjson.sign.sign_json( | ||
| token["signed"], |
There was a problem hiding this comment.
This doesn't seem to be identical behaviour: you've dropped the "token" key from the dict that's being signed?
Is there some reason why this is justifiable?
There was a problem hiding this comment.
No. I'm not sure what I was thinking here. I'll take another look.
|
Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #414
I was sad to get rid of the
TypedDictfromsydent.db.invite_tokens, but given that we immediately use it by adding extra keys, it wasn't worth the effort. Oh well.