Make sydent.terms pass mypy --strict
#428
Conversation
Shout out to getForClient, which a) mixes presentation with data and b) was a massive PITA to type hint. It's very very stringly typed. Part of #414
|
|
||
| # Ensure we're dealing with unicode. | ||
| if version and isinstance(version, bytes): | ||
| version = version.decode("UTF-8") |
There was a problem hiding this comment.
I'm confused why its safe to remove the bytes check?
There was a problem hiding this comment.
versioncomes fromself._rawTermsself._rawTermsis a dict, set in the constructor. I can't see anywhere that it's mutated.- It'll be set to either None or
yaml.safe_load(...) - AFAIK the latter can't produce a
bytesobject....
But that last bullet isn't correct. There's a !!binary "language independent scalar type" in YAML. So I guess it's possible that this could be a bytes object.
I am incredibly tempted to just pull in jsonschema and use that to enforce the config shape and type.
There was a problem hiding this comment.
...but I've refrained and checked the string type after we load the yaml.
There was a problem hiding this comment.
Cool, that works. In general the flow is a bit weird here as we validate the data, then pass around the dict and then pull out data from it, which means its quite hard to see what has been validated and what hasn't. But let's not fix that up in a typing PR.
Part of #414
I was sad to get rid of the
TypedDictfromsydent.db.invite_tokens, but given that we immediately use it by adding extra keys, it wasn't worth the effort. Oh well.