Get sydent.http.auth passing mypy --strict

[DMRobertson]

No description provided.

[babolivier]

Are we sure at this point that terms is not None? It's possible to run Python code in a configuration that ignore assert statements so we're trying to limit our use of them to double checking conditions we're reasonably sure we're not going to hit. If there's a realistic possibility of terms being None could you raise normally instead please?

[DMRobertson]

terms is None if and only if the try block in get_terms raises an Exception. That gets immediately caught, logged and suppressed.

sydent/sydent/terms/terms.py

Lines 120 to 160 in 5de7349

	def get_terms(sydent: "Sydent") -> Optional[Terms]:
	"""Read and parse terms as specified in the config."""
	# TODO - move some of this to parse_config
	termsPath = sydent.config.general.terms_path
	try:
	if termsPath == "":
	return Terms(None)
	with open(termsPath) as fp:
	termsYaml = yaml.safe_load(fp)
	# TODO use something like jsonschema instead of this handwritten code.
	if "master_version" not in termsYaml:
	raise Exception("No master version")
	elif not isinstance(termsYaml["master_version"], str):
	raise TypeError(
	f"master_version should be a string, not {termsYaml['master_version']!r}"
	)
	if "docs" not in termsYaml:
	raise Exception("No 'docs' key in terms")
	for docName, doc in termsYaml["docs"].items():
	if "version" not in doc:
	raise Exception("'%s' has no version" % (docName,))
	if "langs" not in doc:
	raise Exception("'%s' has no langs" % (docName,))
	for langKey, lang in doc["langs"].items():
	if "name" not in lang:
	raise Exception(
	"lang '%s' of doc %s has no name" % (langKey, docName)
	)
	if "url" not in lang:
	raise Exception(
	"lang '%s' of doc %s has no url" % (langKey, docName)
	)
	return Terms(termsYaml)
	except Exception:
	logger.exception("Couldn't read terms file '%s'", termsPath)
	return None

I could allow get_terms to raise and have its return type be Terms?