Add prometheus-client and sentry-sdk as extras
#501
Conversation
I haven't used a specific version, because these were installed on matrix.org and vector.im using `pip install --upgrade`.
At least, enough annotations for the functions we use. We only use prometheus_client for one function, but it's not annotated.
|
typechecker pain not fixed GRR |
DMRobertson
force-pushed
the
dmr/monitoring-extras
branch
from
8b1e728 to
3735867
Compare
not sure why this didn't crop up before.
DMRobertson
force-pushed
the
dmr/monitoring-extras
branch
from
3735867 to
7fff8da
Compare
| version = "1.5.5" | ||
| description = "Python client for Sentry (https://sentry.io)" | ||
| category = "main" | ||
| optional = false |
There was a problem hiding this comment.
This one alarmed me. The intent is to make sentry-sdk optional at runtime but required at dev-time.
But I think this is actually fine as it is. A fresh --no-dev installation created as follows didn't include sentry.
poetry shell
# nuke poetry's venv
pip freeze | cut -d " " -f 1 | xargs pip uninstall -y
poetry install --no-dev
pip list | grep 'sentry' # no resultsA fresh install with dev dependencies did include sentry:
pip freeze | cut -d " " -f 1 | xargs pip uninstall -y
poetry install
...
• Installing sentry-sdk (1.5.5)
...
And for completeness I checked what happened when installing from a wheel. That didn't install sentry.
```shell
poetry build
cd /tmp
python -m venv env
source env/bin/activate
pip install ~/workspace/sydent/dist/matrix_sydent-2.5.1-py3-none-any.whl
pip list | grep sentry # no outputThere was a problem hiding this comment.
The intent is to make sentry-sdk optional at runtime but required at dev-time.
What's the rationale for requiring it at dev-time?
pyproject.toml
Outdated
| # sentry_sdk is required for typechecking. | ||
| sentry_sdk = "*" |
There was a problem hiding this comment.
Above you write sentry-sdk with a hyphenminus; here an underscore. Should this be a hyphenminus too?
There was a problem hiding this comment.
Yes, thank you. (The distribution name is sentry-sdk; the package it provides is sentry_sdk.)
There was a problem hiding this comment.
I think there's some normalisation going on behind the scenes here, but let's be consistent.
I haven't used a specific version, because these were installed on
matrix.org and vector.im using
pip install --upgrade.