Fix a long-standing spec compliance bug where Synapse would accept a …

…trailing slash on the end of `/get_missing_events` federation requests. (#13789) * Don't accept a trailing slash on the end of /get_missing_events * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]> Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
matrix-org · Sep 14, 2022 · 21687ec · 21687ec
1 parent 12dacec
commit 21687ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/changelog.d/13789.bugfix b/changelog.d/13789.bugfix
@@ -0,0 +1 @@
+Fix a long-standing spec compliance bug where Synapse would accept a trailing slash on the end of `/get_missing_events` federation requests.
diff --git a/synapse/federation/transport/server/federation.py b/synapse/federation/transport/server/federation.py
@@ -549,8 +549,7 @@ async def on_POST(
 
 
 class FederationGetMissingEventsServlet(BaseFederationServerServlet):
-    # TODO(paul): Why does this path alone end with "/?" optional?
-    PATH = "/get_missing_events/(?P<room_id>[^/]*)/?"
+    PATH = "/get_missing_events/(?P<room_id>[^/]*)"
 
     async def on_POST(
         self,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a long-standing spec compliance bug where Synapse would accept a trailing slash on the end of `/get_missing_events` federation requests.