Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove unused public room list timeout param (#6179)
Browse files Browse the repository at this point in the history
  • Loading branch information
anoadragon453 committed Feb 26, 2020
2 parents 6b9f0e9 + ea7d938 commit 2351bbe
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
1 change: 1 addition & 0 deletions changelog.d/6179.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove unused `timeout` parameter from `_get_public_room_list`.
13 changes: 1 addition & 12 deletions synapse/handlers/room_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,8 @@ def get_local_public_room_list(
# appservice specific lists.
logger.info("Bypassing cache as search request.")

# XXX: Quick hack to stop room directory queries taking too long.
# Timeout request after 60s. Probably want a more fundamental
# solution at some point
timeout = self.clock.time() + 60
return self._get_public_room_list(
limit,
since_token,
search_filter,
network_tuple=network_tuple,
timeout=timeout,
limit, since_token, search_filter, network_tuple=network_tuple
)

key = (limit, since_token, network_tuple)
Expand All @@ -118,7 +110,6 @@ def _get_public_room_list(
search_filter=None,
network_tuple=EMPTY_THIRD_PARTY_ID,
from_federation=False,
timeout=None,
):
"""Generate a public room list.
Args:
Expand All @@ -131,8 +122,6 @@ def _get_public_room_list(
Setting to None returns all public rooms across all lists.
from_federation (bool): Whether this request originated from a
federating server or a client. Used for room filtering.
timeout (int|None): Amount of seconds to wait for a response before
timing out. TODO
"""

# Pagination tokens work by storing the room ID sent in the last batch,
Expand Down

0 comments on commit 2351bbe

Please sign in to comment.