Land improved room list based on room stats (#6019)

matrix-org · Feb 26, 2020 · 4ab5cf8 · 4ab5cf8
2 parents 3a2008d + a5166e4
commit 4ab5cf8
Show file tree

Hide file tree

Showing 7 changed files with 273 additions and 350 deletions.
diff --git a/changelog.d/6019.misc b/changelog.d/6019.misc
@@ -0,0 +1 @@
+Improve performance of the public room list directory.
diff --git a/synapse/federation/transport/server.py b/synapse/federation/transport/server.py
@@ -765,6 +765,10 @@ async def on_GET(self, origin, content, query):
         else:
             network_tuple = ThirdPartyInstanceID(None, None)
 
+        if limit == 0:
+            # zero is a special value which corresponds to no limit.
+            limit = None
+
         data = await maybeDeferred(
             self.handler.get_local_public_room_list,
             limit,
@@ -800,6 +804,10 @@ async def on_POST(self, origin, content, query):
         if search_filter is None:
             logger.warning("Nonefilter")
 
+        if limit == 0:
+            # zero is a special value which corresponds to no limit.
+            limit = None
+
         data = await self.handler.get_local_public_room_list(
             limit=limit,
             since_token=since_token,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Improve performance of the public room list directory.