Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Commit

Permalink
Remove the hotfix-specific hack for auth on room_members
Browse files Browse the repository at this point in the history
This reverts fae708c.

We believe this to be unnecessary---other Synapse deployments do not
have this patch, and we are not aware of bridging problems as a result.

Related:

- matrix-org/matrix-appservice-irc#506
- #4826
  • Loading branch information
David Robertson committed Aug 23, 2022
1 parent 7c59528 commit 7ba0336
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions synapse/handlers/message.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,7 @@ async def get_joined_members(self, requester: Requester, room_id: str) -> dict:
# This can either be because the AS user is in the room or because there
# is a user in the room that the AS is "interested in"
if (
False # See https://github.com/matrix-org/matrix-appservice-irc/issues/506
# and https://github.com/matrix-org/synapse/issues/4826#issuecomment-1028105662
and requester.app_service
requester.app_service
and requester.user.to_string() not in users_with_profile
):
for uid in users_with_profile:
Expand Down

0 comments on commit 7ba0336

Please sign in to comment.