This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add an admin API to check if a username is available (#10578)
This adds a new API GET /_synapse/admin/v1/username_available?username=foo to check if a username is available. It is the counterpart to https://matrix.org/docs/spec/client_server/r0.6.0#get-matrix-client-r0-register-available, except that it works even if registration is disabled.
- Loading branch information
Showing
5 changed files
with
136 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add an admin API (`GET /_synapse/admin/username_available`) to check if a username is available (regardless of registration settings). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Copyright 2019 The Matrix.org Foundation C.I.C. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
import logging | ||
from http import HTTPStatus | ||
from typing import TYPE_CHECKING, Tuple | ||
|
||
from synapse.http.servlet import RestServlet, parse_string | ||
from synapse.http.site import SynapseRequest | ||
from synapse.rest.admin._base import admin_patterns, assert_requester_is_admin | ||
from synapse.types import JsonDict | ||
|
||
if TYPE_CHECKING: | ||
from synapse.server import HomeServer | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
class UsernameAvailableRestServlet(RestServlet): | ||
"""An admin API to check if a given username is available, regardless of whether registration is enabled. | ||
Example: | ||
GET /_synapse/admin/v1/username_available?username=foo | ||
200 OK | ||
{ | ||
"available": true | ||
} | ||
""" | ||
|
||
PATTERNS = admin_patterns("/username_available") | ||
|
||
def __init__(self, hs: "HomeServer"): | ||
self.auth = hs.get_auth() | ||
self.registration_handler = hs.get_registration_handler() | ||
|
||
async def on_GET(self, request: SynapseRequest) -> Tuple[int, JsonDict]: | ||
await assert_requester_is_admin(self.auth, request) | ||
|
||
username = parse_string(request, "username", required=True) | ||
await self.registration_handler.check_username(username) | ||
return HTTPStatus.OK, {"available": True} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
# Copyright 2021 The Matrix.org Foundation C.I.C. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import synapse.rest.admin | ||
from synapse.api.errors import Codes, SynapseError | ||
from synapse.rest.client.v1 import login | ||
|
||
from tests import unittest | ||
|
||
|
||
class UsernameAvailableTestCase(unittest.HomeserverTestCase): | ||
servlets = [ | ||
synapse.rest.admin.register_servlets, | ||
login.register_servlets, | ||
] | ||
url = "/_synapse/admin/v1/username_available" | ||
|
||
def prepare(self, reactor, clock, hs): | ||
self.register_user("admin", "pass", admin=True) | ||
self.admin_user_tok = self.login("admin", "pass") | ||
|
||
async def check_username(username): | ||
if username == "allowed": | ||
return True | ||
raise SynapseError(400, "User ID already taken.", errcode=Codes.USER_IN_USE) | ||
|
||
handler = self.hs.get_registration_handler() | ||
handler.check_username = check_username | ||
|
||
def test_username_available(self): | ||
""" | ||
The endpoint should return a 200 response if the username does not exist | ||
""" | ||
|
||
url = "%s?username=%s" % (self.url, "allowed") | ||
channel = self.make_request("GET", url, None, self.admin_user_tok) | ||
|
||
self.assertEqual(200, int(channel.result["code"]), msg=channel.result["body"]) | ||
self.assertTrue(channel.json_body["available"]) | ||
|
||
def test_username_unavailable(self): | ||
""" | ||
The endpoint should return a 200 response if the username does not exist | ||
""" | ||
|
||
url = "%s?username=%s" % (self.url, "disallowed") | ||
channel = self.make_request("GET", url, None, self.admin_user_tok) | ||
|
||
self.assertEqual(400, int(channel.result["code"]), msg=channel.result["body"]) | ||
self.assertEqual(channel.json_body["errcode"], "M_USER_IN_USE") | ||
self.assertEqual(channel.json_body["error"], "User ID already taken.") |