Fix failure to fetch batches of PDUs (#5342)

FederationClient.get_pdu is called in a loop to fetch a batch of PDUs. A failure to fetch one should not result in a failure of the whole batch. Add the missing `continue`.
matrix-org · Jun 4, 2019 · dae224a · dae224a
1 parent b4189b1
commit dae224a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/changelog.d/5342.bugfix b/changelog.d/5342.bugfix
@@ -0,0 +1 @@
+Fix failure when fetching batches of events during backfill, etc.
diff --git a/synapse/federation/federation_client.py b/synapse/federation/federation_client.py
@@ -279,6 +279,7 @@ def get_pdu(self, destinations, event_id, room_version, outlier=False,
                     "Failed to get PDU %s from %s because %s",
                     event_id, destination, e,
                 )
+                continue
             except NotRetryingDestination as e:
                 logger.info(str(e))
                 continue
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix failure when fetching batches of events during backfill, etc.