Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against Twisted trunk is failing #12575

Closed
github-actions bot opened this issue Apr 28, 2022 · 5 comments · Fixed by #12613
Closed

CI run against Twisted trunk is failing #12575

github-actions bot opened this issue Apr 28, 2022 · 5 comments · Fixed by #12613
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022 •
edited
Loading

See https://github.com/matrix-org/synapse/actions/runs/2262619388
@DMRobertson
Copy link
Contributor 


  SolverProblemError

  The current project's Python requirement (>=3.7,<4.0) is not compatible with some of the required packages Python requirement:
    - twisted requires Python >=3.7.1, so it will not be satisfied for Python >=3.7,<3.7.1

Seems to be from twisted/twisted@3bbe558#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52L29 i.e. twisted/twisted#1724

@DMRobertson
Copy link
Contributor

DMRobertson commented Apr 28, 2022 •
edited
Loading

This commit in particular sheds light on the rationale: twisted/twisted@a3a08a1 (#1724)

@H-Shay
Copy link
Contributor

H-Shay commented Apr 28, 2022

What (if anything) do we need to do to resolve this?

@DMRobertson
Copy link
Contributor

We could

  • change Synapse to bump its minimum required version to 3.7.1 too
  • ask Twisted why they now require Python >=3.7.1, and possibly persuade them otherwise.
  • ignore the twisted trunk CI job for the time being, and choose one of the two options above closer to the next release of Twisted

@DMRobertson DMRobertson mentioned this issue Apr 28, 2022
Merged
7 tasks
@DMRobertson
Copy link
Contributor

Discussed in #synapse-dev. Let's bump our version and see if that causes any problems. Should be a case of changing ^3.7 to 3.7.1 in pyproject.toml, followed by poetry lock --no-update.

@DMRobertson DMRobertson self-assigned this Apr 29, 2022
DMRobertson pushed a commit that referenced this issue May 3, 2022
Bump Synapse minimum Python version to 3.7.1
4ca3279 
This is presumably a minimum CPython version; I don't
think the abstract language has point releases.

Resolves #12575.
@DMRobertson DMRobertson mentioned this issue May 3, 2022
Merged
@DMRobertson DMRobertson added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Synapse minimum Python version to 3.7.1 matrix-org/synapse
2 participants
@DMRobertson @H-Shay