Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Deny server ACL events in C-S API which would block the server #4042

Closed
erikjohnston opened this issue Oct 16, 2018 · 2 comments · Fixed by #8708
Closed

Deny server ACL events in C-S API which would block the server #4042

erikjohnston opened this issue Oct 16, 2018 · 2 comments · Fixed by #8708
Assignees
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

Its quite easy to accidentally send a server ACL event that blocks everyone, including the current server. I can't think of a time when you would want to block your own server, so lets just deny client requests that try to set ACLs that would block the current server

@neilisfragile neilisfragile added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label) maintenance labels Oct 19, 2018
@richvdh
Copy link
Member

richvdh commented Jul 14, 2020

the reason this is so bad:

Once you've blocked your own server, there is no way back, because all the other servers in the room will ignore you when you try to unblock yourself.

@erikjohnston
Copy link
Member Author

We should also stop people from redacting server ACLs over the CS API for the same reason; a redacted server ACL is treated as an empty one (in current room versions).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants