This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Do not generate self-signed TLS certificates by default. #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4509 +/- ##
===========================================
- Coverage 74.76% 74.75% -0.01%
===========================================
Files 336 336
Lines 34180 34158 -22
Branches 5559 5558 -1
===========================================
- Hits 25553 25536 -17
+ Misses 7051 7046 -5
Partials 1576 1576 |
|
SyTest PR: matrix-org/sytest#551 |
richvdh
approved these changes
Jan 29, 2019
synapse/config/tls.py
Outdated
| @@ -40,7 +41,9 @@ def read_config(self, config): | |||
| self.acme_reprovision_threshold = acme_config.get("reprovision_threshold", 30) | |||
|
|
|||
| self.tls_certificate_file = os.path.abspath(config.get("tls_certificate_path")) | |||
| self.tls_private_key_file = os.path.abspath(config.get("tls_private_key_path")) | |||
| self.tls_private_key_file = config.get("tls_private_key_path") | |||
| if self.tls_private_key_file: | |||
There was a problem hiding this comment.
there's a self.abspath to do this boilerplate for you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4490