Self-signed certificate notice is being displayed without the certificate being generated

[madonius]

Description

The notice about the self signed certificates is being displayed after the configuration file generation although this was removed in #4509
See:

synapse/synapse/config/_base.py

Line 316 in 3bd9daf

" %r with corresponding SSL keys and self-signed"

Steps to reproduce

Generate the configuration file

Version information

• Homeserver: local test environment

• Version: v0.99.0

• Install method: Docker

• Platform: Docker

[richvdh]

I think this will be fixed by #4619

[madonius]

This is not regarding the docker-specific templating. Rather we just used docker to generate a config file, we used

python -m synapse.app.homeserver \
    --server-name my.domain.name \
    --config-path homeserver.yaml \
    --generate-config \
    --report-stats=no

As described in https://github.com/matrix-org/synapse/blob/master/INSTALL.md

[madonius]

cc @jcgruenhage

[richvdh]

in that case, can you give more details about the repro steps and what symptoms you actually see?

[jcgruenhage]

jcgruenhage  ~  docker run -it --rm --entrypoint /bin/sh docker.io/matrixdotorg/synapse
/ # python -m synapse.app.homeserver \
>     --server-name my.domain.name \
>     --config-path homeserver.yaml \
>     --generate-config \
>     --report-stats=no
A config file has been generated in 'homeserver.yaml' for server name 'my.domain.name' with corresponding SSL keys and self-signed certificates. Please review this file and customise it to your needs.
If this server name is incorrect, you will need to regenerate the SSL certificates

We just used docker to get a throwaway env with a synapse install quickly.
We ran a shell in the container, in which we used synapses good old --generate-config option to generate a config file.
As you can see, after the file was generated, we got a notice about a self signed certificate being created, which is not the case though.

[richvdh]

Right, the warning we are complaining about is this one:

 jcgruenhage  ~  docker run -it --rm --entrypoint /bin/sh docker.io/matrixdotorg/synapse
/ # python -m synapse.app.homeserver \
>     --server-name my.domain.name \
>     --config-path homeserver.yaml \
>     --generate-config \
>     --report-stats=no
A config file has been generated in 'homeserver.yaml' for server name 'my.domain.name' with corresponding SSL keys and self-signed certificates. Please review this file and customise it to your needs.
If this server name is incorrect, you will need to regenerate the SSL certificates

[neilisfragile]

Looks fixed by #4625