Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix bug where synapse fails to start if no_tls set #4524

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Fix bug where synapse fails to start if no_tls set #4524

merged 3 commits into from
Jan 30, 2019

Conversation

erikjohnston
Copy link
Member

Introduced in #4495

@erikjohnston erikjohnston requested a review from a team January 30, 2019 12:17
@erikjohnston erikjohnston removed the request for review from a team January 30, 2019 12:44
@codecov-io
Copy link

codecov-io commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #4524 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #4524      +/-   ##
===========================================
+ Coverage     74.7%   74.73%   +0.03%     
===========================================
  Files          337      337              
  Lines        34447    34447              
  Branches      5615     5615              
===========================================
+ Hits         25732    25745      +13     
+ Misses        7124     7111      -13     
  Partials      1591     1591

@erikjohnston erikjohnston requested a review from a team January 30, 2019 12:48
richvdh
richvdh approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 43c6fca into develop Jan 30, 2019
@gdamjan gdamjan mentioned this pull request Feb 12, 2019
Merged
richvdh pushed a commit that referenced this pull request Feb 14, 2019
@gdamjan @richvdh
implement reload by sending the HUP signal (#4622)
a214ba9 
* implement `reload` by sending the HUP signal

According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:

> Synapse will now reload TLS certificates from disk upon SIGHUP. (#4495, #4524)

So the matrix-synapse.service unit file should include a reload directive.

Signed-off-by: Дамјан Георгиевски <[email protected]>
@erikjohnston erikjohnston deleted the erikj/fix_no_tls branch March 5, 2019 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikjohnston @codecov-io @richvdh