Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

implement reload by sending the HUP signal #4622

Merged
merged 2 commits into from
Feb 14, 2019
Merged

implement reload by sending the HUP signal #4622

merged 2 commits into from
Feb 14, 2019

Conversation

gdamjan
Copy link
Contributor

@gdamjan gdamjan commented Feb 12, 2019

According to the 0.99 release info synapse now uses the HUP signal to reload certificates:

Synapse will now reload TLS certificates from disk upon SIGHUP. (#4495, #4524)

So the matrix-synapse.service unit file should include a reload directive.

According to the 0.99 release info* synapse now uses the HUP signal to reload certificates:
> Synapse will now reload TLS certificates from disk upon SIGHUP. (#4495, #4524)

So the matrix-synapse.service unit file should include a reload directive.

* https://github.com/matrix-org/synapse/releases/tag/v0.99.0

Signed-off-by: Дамјан Георгиевски <[email protected]>
@richvdh
Copy link
Member

richvdh commented Feb 12, 2019

Thanks. Can you add an entry to the debian/changelog?

@gdamjan
Copy link
Contributor Author

gdamjan commented Feb 12, 2019

I'm not sure how that should look, do I put myself as signed?

@richvdh
Copy link
Member

richvdh commented Feb 12, 2019

Probably best to use dch. Try something like dch -v 0.99.1, which will start an UNRELEASED version, and put your name in the maintainer field. It will then open an editor where you can add a suitable entry in the template it gives you.

Later, when we come to do the next release, dch will then put our email address back in the maintainer field and record your contribution like this.

@codecov-io
Copy link

Codecov Report

Merging #4622 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4622      +/-   ##
===========================================
- Coverage    75.31%   75.28%   -0.03%     
===========================================
  Files          338      338              
  Lines        34540    34540              
  Branches      5643     5643              
===========================================
- Hits         26013    26004       -9     
- Misses        6941     6951      +10     
+ Partials      1586     1585       -1

@gdamjan
Copy link
Contributor Author

gdamjan commented Feb 14, 2019

feel free to squash/merge the 2 commits

@richvdh richvdh changed the base branch from develop to release-v0.99.1 February 14, 2019 13:43
@richvdh richvdh merged commit a214ba9 into matrix-org:release-v0.99.1 Feb 14, 2019
@richvdh
Copy link
Member

richvdh commented Feb 14, 2019

thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants