Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Directly start Synapse processes instead of using supervisor for Docker image with workers #10705

Closed
wants to merge 5 commits into from

Conversation

clokep
Copy link
Member

@clokep clokep commented Aug 26, 2021

This attempts to fix #10065.

This takes the suggestion in there to manually start the Synapse processes and wait for it to be ready via the SDNOTIFY stuff (instead of depending on supervisor to start the processes).

Unfortunately at the end of this (while using complement) I seem to end up at the same result as when using supervisor. Complement intermittently cannot get a /versions response.

I'm also unsure if this makes sense if we're asking people to use this image outside of complement since this has no process monitoring.

The core of the change is in the second commit, but I'm not really sure where to go from here. 😢

I was testing this with: COMPLEMENT_DIR=<...> WORKERS=1 ./scripts-dev/complement.sh TestVersionStructure from the synapse root

@clokep
Copy link
Member Author

clokep commented Sep 10, 2021

I'm going to close this, but if someone wants to pick this open do feel free to reuse this branch / PR!

@clokep clokep closed this Sep 10, 2021
@clokep clokep deleted the clokep/complement-workers branch May 31, 2022 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synapse workers Complement image results in flaky tests due to inconsistent worker process init
1 participant