This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Directly start Synapse processes instead of using supervisor for Docker image with workers #10705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #10065.
This takes the suggestion in there to manually start the Synapse processes and wait for it to be ready via the
SDNOTIFY
stuff (instead of depending on supervisor to start the processes).Unfortunately at the end of this (while using complement) I seem to end up at the same result as when using supervisor. Complement intermittently cannot get a
/versions
response.I'm also unsure if this makes sense if we're asking people to use this image outside of complement since this has no process monitoring.
The core of the change is in the second commit, but I'm not really sure where to go from here. 😢
I was testing this with:
COMPLEMENT_DIR=<...> WORKERS=1 ./scripts-dev/complement.sh TestVersionStructure
from the synapse root