Build Docker images for using worker-mode Synapse in automated test tools. #11852
Conversation
reivilibre
force-pushed
the
rei/docker_workers_for_testing
branch
from
df34a07 to
a6d034f
Compare
Signed-off-by: Olivier Wilkinson (reivilibre) <[email protected]>
reivilibre
force-pushed
the
rei/docker_workers_for_testing
branch
from
a6d034f to
e940c62
Compare
| run: docker buildx inspect | ||
|
|
||
| - name: Login to GitHub Container Registry (for worker-testing-only image) | ||
| if: github.event_name != 'pull_request' |
There was a problem hiding this comment.
it looks like the push is not conditional on this, so why is the login?
(maybe we can make the entire job conditional instead of the individial steps?)
| - name: Inspect builder | ||
| run: docker buildx inspect | ||
|
|
||
| - name: Login to GitHub Container Registry (for worker-testing-only image) |
There was a problem hiding this comment.
the "(for worker-testing-only image)" is a bit weird here. Why only this step?
| username: ${{ github.repository_owner }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| # This must match EXACTLY the one in the `build` pipeline. |
There was a problem hiding this comment.
could use a yaml alias thingy to avoid the duplication
There was a problem hiding this comment.
anchor and merge are the formal names, I think.
There was a problem hiding this comment.
Apparently GHA doesn't support YAML anchors. I was surprised but this is what the net says.
| esac | ||
| echo "::set-output name=tag::$tag" | ||
|
|
||
| # This image is solely intended to be used for automated test tools, |
There was a problem hiding this comment.
.oO (we should probably use https://github.com/peter-evans/dockerhub-description to upload/sync the image descriptions on ghcr/dockerhub)
|
Turns out this wasn't flexible enough, so mx-tester builds its own image now (I think). |
This is wanted by mx-tester.