Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix appservice EDUs failing to send if the EDU doesn't have a room ID #13236

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Fix appservice EDUs failing to send if the EDU doesn't have a room ID #13236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d65784
Fix appservice EDUs failing to send if the EDU doesn't have a room ID
turt2live Jul 9, 2022
cef3b0c
changelog
turt2live Jul 9, 2022
bec49be
linter
turt2live Jul 9, 2022
d2451f5
fix linter again
turt2live Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/13236.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix appservices not receiving room-less EDUs, like presence, if enabled.
4 changes: 3 additions & 1 deletion synapse/appservice/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,9 @@ async def _compute_msc3202_otk_counts_and_fallback_keys(
rooms_of_interesting_users.update(event.room_id for event in events)
# EDUs
rooms_of_interesting_users.update(
ephemeral["room_id"] for ephemeral in ephemerals
ephemeral["room_id"]
for ephemeral in ephemerals
if ephemeral.get("room_id") is not None
)

# Look up the AS users in those rooms
Expand Down