This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Log when we get an invalid body on certain CS-API requests #13386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some endpoints currently accept an invalid JSON object in the request body, which we should stop. As a starting point, let's log when it happens so that we can fix it.
richvdh
force-pushed
the
rav/log_invalid_bodies
branch
from
2a915bb to
dd59f1e
Compare
squahtx
approved these changes
Jul 26, 2022
|
oh, hrm, I'd failed to grasp that. let me have another look. |
|
yeah, I don't need this. Sorry about the noise! |
|
cf #13388 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some endpoints currently accept an invalid JSON object in the request body,
which we should stop. As a starting point, let's log when it happens so that we
can fix it.