This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update development docs referencing versions of sqlite we no longer support #15498
Update development docs referencing versions of sqlite we no longer support #15498
Changes from 3 commits
0d55f88
fe86db5
4710b40
e93b15b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we file an issue to track doing this for any current queries? I don't know how easy that would be to find, but I definitely know I've written a few where I purposefully pass in
True
orFalse
as parameters...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean open an issue to covert queries like this:
synapse/synapse/storage/databases/main/purge_events.py
Lines 251 to 258 in 57aeeb3
currently in the code base to use the
IS [NOT] TRUE
/IS [NOT] FALSE
operators (presumably because it's easier to understand that way)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I mean.
I feel less strongly about converting
=
toIS
than just inlining the variables: I think reducing the number of placeholders makes the queries clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right on I'll open an issue for that. Edit: this is #15515