This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use parse and asserts from http.servlet #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parse_integer and parse_string can take a request and raise errors in case we have wrong or missing params. This PR tries to use them more to deduplicate some code and make it better readable
the method "assert_params_in_request" does handle dicts and not requests. A request body has to be parsed to json before this method can be used
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
matrixbot: test this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.server contains methods to parse requests and throw SynapseErrors when there is something wrong.
That can be a missing required param or a string which cannot be parsed to int.
This methods should be used in order to deduplicate checks.
On top of that the method
assert_params_in_requestgot renamed toassert_params_in_dictas it does not handle request objects but dicts