This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Always calculate heroes for rooms without avatars #3898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matrixbot retest this please |
|
/me investigates tests |
|
@matrixbot please retest this again |
|
retest this please |
|
How bad would it be if we always sent down heroes? It doesn't feel like it'd add that much overhead, and yet be a lot simpler? That way we don't have to guess if/when a client would want them (it would also allow the client to always show some members in a room while they're loading the rest?) |
|
Also: What are all the failing tests about? |
manuroe
added a commit
to matrix-org/matrix-ios-sdk
that referenced
this pull request
Sep 19, 2018
It requires matrix-org/synapse#3898 to work correctly
|
see also #5089 which appears to duplicate some of the work done while this has been bit-rotting :/ |
|
I think this would need to be rebased and it sounds like at least some of this was done already. I'm going to close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise clients may not have the membership events they need to generate an avatar for the room (typically a 1:1, but if a client chose to montage together multiple avatars, that'd break too)
Tests over at matrix-org/sytest#493