Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support starting with no_tls = True and no TLS certificates #4606

Closed
wants to merge 10 commits into from

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Feb 11, 2019

No description provided.

@hawkowl hawkowl requested a review from a team February 11, 2019 09:14
@richvdh
Copy link
Member

richvdh commented Feb 11, 2019

looks like this is based on #4522

@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@c475275). Click here to learn what that means.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             develop    #4606   +/-   ##
==========================================
  Coverage           ?   75.04%           
==========================================
  Files              ?      338           
  Lines              ?    34468           
  Branches           ?     5619           
==========================================
  Hits               ?    25865           
  Misses             ?     7022           
  Partials           ?     1581

if not self.no_tls:
self.tls_private_key = self.read_tls_private_key(self.tls_private_key_file)

self.tls_fingerprints = list(self._original_tls_fingerprints)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not important?

@richvdh
Copy link
Member

richvdh commented Feb 11, 2019

sorry, have superceded this with #4618 and co

@richvdh richvdh closed this Feb 11, 2019
@hawkowl hawkowl deleted the hawkowl/no-tls branch May 21, 2019 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants