This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnature check. If an event does fail a signature check, look in the local database and request it from the originator.
… persist_event check if we already have the event, if so then update instead of replacing so that we don't cause a bump of the stream_ordering.
…at we can use it to check signatures for events on old servers
…oint keeping it around :(
Jenkins: Test this please |
Or.... test this please? |
events = yield self._get_events([event_id]) | ||
def get_event(self, event_id, check_redacted=True, | ||
get_prev_content=False, allow_rejected=False, | ||
allow_none=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to add a bit of doc string for the get_event now that it has a few parameters.
…ne before returning early if we have already persisted that event.
…context.current_state, rather than based on the auth_events from the event.
Can someone have a look at this again please? It passes sytest now :) |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
This is a performance-related improvement to #13, which queried and hid active *and* already inactive users, one-by-one. This PR updates the code to query only **active**, expired users, all at once, and then mark them as inactive, all at once.
Fizzadar
pushed a commit
to Fizzadar/synapse
that referenced
this pull request
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.