Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

remove urllib3 pin #5230

Merged
merged 2 commits into from
May 22, 2019
+1 −8
Merged

remove urllib3 pin #5230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e10f31
remove urllib3 pin
Bubu May 22, 2019
269dc2a
add changelog entry
Bubu May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/5230.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove urllib3 pin as requests 2.22.0 has been released supporting urllib3 1.25.2.
8 changes: 0 additions & 8 deletions synapse/python_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,6 @@
"attrs>=17.4.0",

"netaddr>=0.7.18",

# requests is a transitive dep of treq, and urlib3 is a transitive dep
# of requests, as well as of sentry-sdk.
#
# As of requests 2.21, requests does not yet support urllib3 1.25.
# (If we do not pin it here, pip will give us the latest urllib3
# due to the dep via sentry-sdk.)
"urllib3<1.25",
]

CONDITIONAL_REQUIREMENTS = {
Expand Down