Allow appservice bots to use /sync #5758
Conversation
Signed-off-by: Tulir Asokan <[email protected]>
|
@tulir can you merge this PR forward please? |
|
please can someone take a look at this? i think the reason we removed it originally was because the AS /sync codepath wasn't tested and bitrotted, and at the time there wasn't anyone using it so we removed it rather than maintain it. But @tulir's use case is decent and it'd be good to support it. |
|
neil to have a look at this ticket and decide how to prioritise it |
|
Immediate need has passed, so waiting on the MSC to work through the spec process |
Looks like synapse isn't going to be fixed soon (matrix-org/synapse#5758), so this changes all registrations to be generated using the workaround: the sender_localpart is set to a random string and the actual AS bot is added as another namespace.
Looks like synapse isn't going to be fixed soon (matrix-org/synapse#5758), so this changes all registrations to be generated using the workaround: the sender_localpart is set to a random string and the actual AS bot is added as another namespace.
|
prod prod |
|
Hello all |
Disagree immediate need has passed - see follow-ups. (And, well, even it it wasn't immediate in 2019, it is, now) |
|
This has been discussed as part of the related MSC2190, where the decision was made to postpone it. As such, I'm going to close this PR and we can reopen if and when the MSC gets resurrected. |
This allows appservices to use /sync as the appservice bot by simply removing the special-casing of appservice bots.
Related spec proposal: matrix-org/matrix-spec-proposals#2190
Pull Request Checklist