This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add type hints to the spam check module #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/spam-checker-types
branch
from
d5a3e9d to
e998c3c
Compare
clokep
changed the title
clokep
force-pushed
the
clokep/spam-checker-types
branch
from
e998c3c to
3252160
Compare
richvdh
approved these changes
Feb 14, 2020
| self.hs = hs | ||
|
|
||
| self._store = hs.get_datastore() | ||
|
|
||
| @defer.inlineCallbacks | ||
| def get_state_events_in_room(self, room_id, types): | ||
| def get_state_events_in_room(self, room_id: str, types: tuple) -> defer.Deferred: |
There was a problem hiding this comment.
generally we've been declaring bankruptcy when trying to declare the return type of @defer.inlineCalbacks functions; the problem being that it's only the decorated version of the function that actually returns a Deferred and mypy etc get confused when you try to return state.values() instead.
Instead we either convert to async/await first, or just leave the return type unannotated.
There was a problem hiding this comment.
Interesting. I can just remove the return type for now if that matches what is done in other places.
There was a problem hiding this comment.
it doesn't matter. I'd just land it.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '10027c80b': Add type hints to the spam check module (#6915)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type hints to the spam check module and has mypy check it.
This is my first foray into typing so hopefully I didn't do anything crazy.
I spun this out of #6906 since I couldn't get it working, but I've since fixed the issue.