Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix unread counts in sync #7716

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix unread counts in sync #7716

merged 1 commit into from
Jun 17, 2020

Conversation

babolivier
Copy link
Contributor

  • Always return an unread_count in get_unread_event_push_actions_by_room_for_user
  • Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong

@babolivier
Fix unread counts in sync
5a5cf64 
* Always return an unread_count in get_unread_event_push_actions_by_room_for_user
* Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
@babolivier babolivier requested a review from a team June 17, 2020 14:11
richvdh
richvdh approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@babolivier babolivier merged commit e35d44c into develop Jun 17, 2020
@babolivier babolivier deleted the babolivier/unread_fix branch June 17, 2020 14:44
babolivier added a commit that referenced this pull request Jun 23, 2020
@babolivier
Revert "Merge pull request #7716 from matrix-org/babolivier/unread_fix"
d7c588b 
This reverts commit e35d44c, reversing
changes made to 3630825.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@babolivier @richvdh