This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix failures in Debian packaging #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes matrix-org#9073 Signed-off-by: Dan Callahan <[email protected]>
Fixes matrix-org#9076 Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
|
Cancelled CI since we don't test the Debian build scripts in CI. Currently building all debs locally to ensure things work. Stretch completed successfully, and I expect no further failures. |
callahad
commented
Jan 12, 2021
callahad
commented
Jan 12, 2021
| xmlsec1 \ | ||
| && ( env DEBIAN_FRONTEND=noninteractive apt-get install \ | ||
| -yqq --no-install-recommends -o Dpkg::Options::=--force-unsafe-io \ | ||
| dh-systemd || true ) |
There was a problem hiding this comment.
Per GitHub comment above, this basically says "try to install dh-systemd, but it's OK if it fails or doesn't exist."
dh-systemd exists as a dummy transitional package on all releases except Ubuntu xenial (sans backports), where we actually do need it. So we need to try to install it. However, the transitional package was removed in Debian Bullseye, so we have to gracefully continue even if the package does not exist.
...all this goes away when we drop Xenial support in ~2 months.
richvdh
suggested changes
Jan 12, 2021
This comment has been minimized.
This comment has been minimized.
richvdh
reviewed
Jan 12, 2021
Signed-off-by: Dan Callahan <[email protected]>
Signed-off-by: Dan Callahan <[email protected]>
richvdh
reviewed
Jan 12, 2021
richvdh
approved these changes
Jan 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian package builds were failing for two reasons:
Python versions prior to 3.7 throw exceptions when attempting to print Unicode characters under a "C" locale.
We depended on
dh-systemdwhich no longer exists in Debian Bullseye, but is necessary in Ubuntu Xenial.Fixing the first issue is as easy as setting
LANG="C.UTF-8"in the build environment. (See https://bugs.python.org/issue19846)Fixing the second issue requires attempting to install
dh-systemd, but ignoring failures when it does not exist.Specifically, the
dh-systemdpackage was merged with the maindebhelperpackage as of debhelper (>= 9.20160709)` and a transitional package was left in its place.That transitional package was removed in Debian Bullseye after being present in both Stretch and Buster. Thus, on the Debian side, just removing the dependency on
dh-systemdwould be sufficient.However, Ubuntu Xenial has an old
debhelperversion, and thus actually needsdh-systemd. So we still try to install it on all distros, but ignore when that fails.Once we drop support for Xenial (March 2021?) we can completely remove anything referencing
dh-systemd.Fixes #9073
Fixes #9076