Pass format, url as data and http as a kind to /pushers/set #1132
Conversation
| @@ -50,7 +52,8 @@ | |||
| assert_eq( $pusher->{device_display_name}, $device_display_name, "device_display_name"); | |||
| assert_eq( $pusher->{pushkey}, $pushkey, "pushkey"); | |||
| assert_eq( $pusher->{lang}, $lang, "lang"); | |||
| assert_eq( $pusher->{data}{testcustom}, $customdata, "custom data"); | |||
There was a problem hiding this comment.
I think we still want to ensure that custom fields are passed through.
Looking at the push gateway spec, data that is sent to the push gateway should be:
A dictionary of additional pusher-specific data. For 'http' pushers, this is the data dictionary passed in at pusher creation minus the
urlkey.
I think the changes should be:
- Keep the custom field.
- Ensure the custom field,
formatare both passed through. - Ensure the
urlis not passed through.
There was a problem hiding this comment.
I think this looks OK, but I'm unsure if url should be there or not, going to see what others think.
There was a problem hiding this comment.
this is checking the response from GET /r0/pushers, rather than the data sent to the push gateway. This looks correct to me.
| @@ -50,7 +52,8 @@ | |||
| assert_eq( $pusher->{device_display_name}, $device_display_name, "device_display_name"); | |||
| assert_eq( $pusher->{pushkey}, $pushkey, "pushkey"); | |||
| assert_eq( $pusher->{lang}, $lang, "lang"); | |||
| assert_eq( $pusher->{data}{testcustom}, $customdata, "custom data"); | |||
There was a problem hiding this comment.
this is checking the response from GET /r0/pushers, rather than the data sent to the push gateway. This looks correct to me.
|
@PiotrKozimor please can you sign off your contribution, per https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off ? |
richvdh
added
the
X-Awaiting-Changes
|
@richvdh I have signed off this PR. |
|
thank you! |
According to documentation (https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-pushers-set)
kindfield can behttp,emailornull(although it's not defined as an enum). Also homeserver should not respecttestcustombecausePusherDatais defined with another fields.Signed-off-by: Piotr Kozimor [email protected]