Fix missing fi in bootstrap.sh
#1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I guess we never noticed this because no-one build and deployed the sytest containers?
anoadragon453
approved these changes
Sep 9, 2021
|
The sytest dendrite failure looks like a flake, which I've noted in matrix-org/dendrite#2007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess we never noticed this because no-one build and deployed the
sytest containers?
Context: I wasn't able to reproduce sytest failures from elsewhere and wanted to ensure I was running the latest version. Building the docker images locally and then trying to run tests with them failed with an error in bootstrap.sh