Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to deflake Forgotten room messages cannot be paginated #1147

Merged
merged 4 commits into from
Oct 7, 2021

Conversation

DMRobertson
Copy link
Contributor

Recommend reviewing commit-by-commit.

Fixes #1116
(hopefully)

@DMRobertson DMRobertson requested a review from a team October 5, 2021 17:32
@DMRobertson DMRobertson requested a review from squahtx October 7, 2021 17:16
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DMRobertson
Copy link
Contributor Author

Merging in spite of failures---no new Dendrite failures.

@DMRobertson DMRobertson merged commit c1163b7 into develop Oct 7, 2021
@DMRobertson DMRobertson deleted the dmr/deflake-forget-test branch October 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forgotten room messages cannot be paginated is flaky
3 participants