Attempt to deflake uploading signed devices gets propagated over federation
#1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
previously requested changes
Nov 18, 2021
Co-authored-by: Andrew Morgan <[email protected]>
richvdh
reviewed
Nov 18, 2021
richvdh
changed the title
uploading signed devices gets propagated over federation
richvdh
reviewed
Nov 19, 2021
Comment on lines
691
to
692
| $content->{device_keys}->{$user2_id}->{$user2_device}->{"signatures"} | ||
| or die "No 'signatures' key present"; |
There was a problem hiding this comment.
is it sufficient to wait for anything at $content->{device_keys}{$user2_id}{$user2_device}, or do we need to wait for there to be a signatures element?
There was a problem hiding this comment.
As I understand it, we need to wait for the signatures in particular.
On server1:
- user2 joins a room
- user2 uploads signatures
On server0, user1 syncs until they see user2's device. This is racey: the sync may complete before the signatures have uploaded, propagated over federation and then over replication.
There was a problem hiding this comment.
right. please could you add these words to a comment in the code.
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
richvdh
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1167 hopefully.