Add push_server.disable_tls_validation to Dendrite configuration #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewer: @kegsay |
kegsay
reviewed
Dec 1, 2021
This disables the TLS certificate check for Push gateways, similar to the Synapse configuration.
tommie
force-pushed
the
http_client_tls_insecure_skip_verify_for_testing
branch
from
dea870d to
69dd8d3
Compare
68 tasks
tommie
changed the title
|
See matrix-org/dendrite#1842 (comment) for the commit ordering relative Dendrite. |
|
@PiotrKozimor raised the question if this can be merged before the config option has been added to Dendrite. I've assumed that Dendrite will fail if we try, but maybe that's not the case? |
|
... and @neilalexander just answered it's okay on the Dendrite 1842. |
|
I removed the review on synapse-core since I don't think it is necessary here. Please shout if you'd like us to take a look though! |
neilalexander
approved these changes
Dec 16, 2021
| ( ! defined $ENV{'POSTGRES'} || $ENV{'POSTGRES'} == '0') ? | ||
| "file:$self->{hs_dir}/mscs.db" : $db_uri, | ||
| }, | ||
| mscs => ["msc2836", "msc2946", "msc2444", "msc2753"], | ||
| }, | ||
|
|
||
| push_server => { |
There was a problem hiding this comment.
@tommie I just realized that we already have push_server section below
There was a problem hiding this comment.
I've fixed that. Good catch.
There was a problem hiding this comment.
Sorry about that. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the TLS certificate check for Push gateways. Sytest uses HTTPS, but with a self-signed certificate. Synapse already has an option like this.
Dendrite-side must be committed first: matrix-org/dendrite#2061