Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that events to be created have required fields #1212

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 12, 2022

DataStore::create_event will complain if these fields are missing. By adding
a extra check here, we'll get a more useful error which gives us a better clue
about where the problem is.

`DataStore::create_event` will complain if these fields are missing. By adding
a extra check here, we'll get a more useful error which gives us a better clue
about where the problem is.
@richvdh richvdh requested a review from a team as a code owner March 12, 2022 17:05
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richvdh richvdh merged commit c4f57b9 into develop Mar 21, 2022
@richvdh richvdh deleted the rav/create_event_check branch March 21, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants