Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect pip invocation when checking deps in offline mode #1245

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix incorrect pip invocation when checking deps in offline mode #1245

merged 1 commit into from
Apr 21, 2022

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Apr 21, 2022 •
edited
Loading

Fixes bug introduced in #1244. CI didn't trip because it only happens in offline mode.

@squahtx squahtx requested a review from a team as a code owner April 21, 2022 13:47
DMRobertson
DMRobertson approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Sorry I missed this.

@squahtx squahtx merged commit a1b3533 into develop Apr 21, 2022
@squahtx squahtx deleted the squah/dont_install_git_dependencies_during_synapse_offline_install_2 branch April 21, 2022 13:59
@squahtx squahtx mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squahtx @DMRobertson