Fix offline mode #1287
Merged
Fix offline mode #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a new build dependency to Synapse so we have to add it to the docker image.
|
CI is failing---is that expected? I can't remember if we have to build docker images first to get Sytest to be happy |
|
@DMRobertson turns out we weren't installing rust. Have now added it to the docker image, but since that isn't rebuilt for PRs I also added it to the GHA job steps. Not sure if we want to remove that before we land it? |
I'd be happy with docker-image only or GHA-only, with a mild preference for docker-image so that it doesn't have to get installed on every run. But also happy if you just want to merge as-is |
DMRobertson
approved these changes
Sep 8, 2022
|
I'll merge as is and then rip out the GHA installation in a separate PR, i think |
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a new build dependency to Synapse so we have to add it to the docker image.
Hopefully fixes matrix-org/synapse#13740