Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mail server to help with 3pid testing #704

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Sep 17, 2019

To help us test the 3pid validation flows, we're going to need a simple SMTP
server. This starts one up, but doesn't do anything with it yet.

To help us test the 3pid validation flows, we're going to need a simple SMTP
server. This starts one up, but doesn't do anything with it yet.
@@ -0,0 +1,124 @@
package SyTest::MailServer;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much of this was cargo-culted from the HTTP equivalents...

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, no obvious errors and the CI passes so 👍

@richvdh richvdh merged commit 6a3d4a2 into develop Sep 18, 2019
@richvdh richvdh deleted the rav/mail_server branch September 18, 2019 10:33
anoadragon453 added a commit that referenced this pull request Mar 18, 2020
…ase-v1.4.0

* origin/release-v1.4.0: (36 commits)
  Improve logging for a failing test (#709)
  Make 3PID binding tests use /account/3pid/bind ala MSC2290 (#703)
  Use unstable prefix for 3PID unbind API
  Add support for handling email validation challenges (#707)
  do requestToken before adding a 3pid (#706)
  Configure synapse to use the test mail server (#705)
  Implement a mail server to help with 3pid testing (#704)
  federated_rooms_fixture (#701)
  Use Sytest develop for Dendrite's master branch (#700)
  Don't assume atomicity
  Fix flakiness due to create_room_synced (#702)
  Don't require an avatar_url
  Replace HOMESERVER_INFO incantations (#699)
  add some logging for flaky sync test (#698)
  Fix problems when using hash
  Accept access_token instead of id_access_token on the IS, accept Authorization header (#697)
  Use hash and handle variable sized final chunk
  Have the in-built identity server support v2 (#689)
  Add tests for 3PID /unbind API (#691)
  Fix typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants