Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metaタグのテストの Symfony4.4 対応 #1

Conversation

okazy
Copy link

@okazy okazy commented Apr 6, 2021

概要(Overview・Refs Issue)

Symfony 4.4 では $this->container->get() でリポジトリが取得できなくなるので先んじて対応しておきました。

refs EC-CUBE#4987

方針(Policy)

実装に関する補足(Appendix)

テスト(Test)

相談(Discussion)

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/seo-product-detail@b0f8d15). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                      @@
##             feature/seo-product-detail       #1   +/-   ##
=============================================================
  Coverage                              ?   76.13%           
  Complexity                            ?     6124           
=============================================================
  Files                                 ?      437           
  Lines                                 ?    20736           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    15788           
  Misses                                ?     4948           
  Partials                              ?        0           
Flag Coverage Δ Complexity Δ
tests 76.13% <0.00%> (?) 0.00% <0.00%> (?%)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f8d15...f48a56c. Read the comment docs.

@matsuoshi matsuoshi merged commit cca46a5 into matsuoshi:feature/seo-product-detail Apr 7, 2021
@matsuoshi
Copy link
Owner

@okazy ありがとうございます! マージしました

matsuoshi pushed a commit that referenced this pull request Aug 30, 2021
…arch

受注のマルチ検索で、会社名はスペースを除去せず検索
shinya pushed a commit that referenced this pull request Mar 12, 2024
… ($string) must be of type string, float given
shinya pushed a commit that referenced this pull request Mar 12, 2024
shinya pushed a commit that referenced this pull request Mar 12, 2024
…orderStateMachine) must be of type Symfony\Component\Workflow\StateMachine, Symfony\Component\Workflow\Debug\TraceableWorkflow given"
shinya pushed a commit that referenced this pull request Mar 12, 2024
…($container) must be of type Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface, Symfony\Component\DependencyInjection\Container given"
shinya pushed a commit that referenced this pull request Mar 12, 2024
…asher::hashPassword(): Argument #1 ($user) must be of type Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants