-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metaタグのテストの Symfony4.4 対応 #1
metaタグのテストの Symfony4.4 対応 #1
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/seo-product-detail #1 +/- ##
=============================================================
Coverage ? 76.13%
Complexity ? 6124
=============================================================
Files ? 437
Lines ? 20736
Branches ? 0
=============================================================
Hits ? 15788
Misses ? 4948
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@okazy ありがとうございます! マージしました |
…arch 受注のマルチ検索で、会社名はスペースを除去せず検索
… ($string) must be of type string, float given
…orderStateMachine) must be of type Symfony\Component\Workflow\StateMachine, Symfony\Component\Workflow\Debug\TraceableWorkflow given"
…($container) must be of type Symfony\Component\DependencyInjection\ParameterBag\ContainerBagInterface, Symfony\Component\DependencyInjection\Container given"
…asher::hashPassword(): Argument #1 ($user) must be of type Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface"
概要(Overview・Refs Issue)
Symfony 4.4 では
$this->container->get()
でリポジトリが取得できなくなるので先んじて対応しておきました。refs EC-CUBE#4987
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目