EUI Barchart and Histogram refactoring #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
* Splitted into line, area, bar, histogram * Added new line chart examples
Reused as much as possible the existing charts implementation and existing event handling
This reverts commit 3340a43.
Add a more generic BarSeries and HistogramSeries, controlled by XYChart orientation prop. Fixed Examples to use this convention instead of single Vertical/Horizontal components. Add the default margin to XYChart.
markov00
changed the title
mattapperson
approved these changes
Jul 3, 2018
sorenlouv
reviewed
Jul 3, 2018
| title={title} | ||
| position={titlePosition} | ||
| orientation={orientation} | ||
| on0={onZero} |
There was a problem hiding this comment.
Shouldn't this be onZero instead of on0?
Btw. onZero sounds more like an event handler than a boolean. Can't come up with a better name from the top of my head though.
There was a problem hiding this comment.
on0 is how react-vis call it. We changed to onZero on our components. Maybe something like isOnZero sounds more like a bool
There was a problem hiding this comment.
agreed, isOnZero is a better name
sorenlouv
reviewed
Jul 3, 2018
|
Still LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduce the following components:
EuiBarSeriesfor bar chartsEuiHistogramSeriesfor histogramsEuiAreaSeriesfor area chartsEuiLineSeriesfor line chartsThe chart can be viewed in vertical (default) or horizontal mode.
A default set of axis is available, but developers can add their own configured axis.
Crosshair and Selection Brush tools are controlled and managed by XYChart.
General features
Charts to be refactored (WIP)
Show/Hide linein favour of scatterplotGeneral Todo:
Discuss:
Notes: The data processing pipeline will take care of process data in the correct format.
Some simple utility function can be built to support chart data format processing.
Notes: It will not be automatically configured to stack series together. The developer needs to know when and how to stack data