Handle console output that is improperly encoded #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbrictson
force-pushed
the
handle-invalid-utf8
branch
3 times, most recently
from
8fdaa7e to
a49a34c
Compare
|
I can confirm that I no longer get the exception 👍 Also now that I don't get the exception any more I noticed that the output coming out of Seems like |
Not sure why, but in some cases the data received from SSHKit claims to be encoded as UTF-8 but is actually invalid. This causes `gsub` to blow up with `ArgumentError: invalid byte sequence in UTF-8` when airbrussh calls `strip_ascii_color`. Work around this by detected invalid encoding and stripping out the offending code points from string before calling `gsub`.
mattbrictson
force-pushed
the
handle-invalid-utf8
branch
from
a49a34c to
06130d1
Compare
|
I don't know where the badly encoded string is coming from but at least airbrussh is now able to deal with it 😄 |
|
Nice. Hope to see a new rubygem release soon. Will point my Gemfile to the master branch in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why, but in some cases the data received from SSHKit claims to be encoded as UTF-8 but is actually invalid. This causes
gsubto blow up withArgumentError: invalid byte sequence in UTF-8when airbrussh callsstrip_ascii_color.Work around this by detecting invalid encoding and stripping out the offending code points from string before calling
gsub.Fixes #120
@dbackeus can you test using this branch to see if this resolves your issue? 🙏