Support removing rake monkey patch #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robd
force-pushed
the
support-removing-rake-monkey-patch
branch
from
9fbe090 to
bfd5204
Compare
When config.monkey_patch_rake=false is called, rake monkey patch is now removed. Improve formatter tests to test rake monkey patching by executing commands via a rake task.
robd
force-pushed
the
support-removing-rake-monkey-patch
branch
from
bfd5204 to
ebdad32
Compare
|
Hmm, I need to revisit this because this doesn't actually work in real life in cases where non SSHKit rake tasks are called.
|
|
capistrano/sshkit#257 has now been merged, breaking Airbrussh against master, so I need to rework all my PRs I think, so please do not merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #13, this improves the rake task formatter logging tests by exercising the rake monkey patch code rather than calling
Airbrussh::Formatter.current_rake_task = "xxx"in the tests.Also adds support for removing the monkey patch if
config.monkey_patch_rake=falseis called.