Minimal changes to restore compatibility with SSHKit master (log_command_* methods) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the new log_command_* methods with minimal changes to the existing Formatter code. This is done by decorating the Command object to make it behave like the legacy version that has stderr/stdout methods, filled with the data passed to log_command_data. The other trick is that to avoid calling @log_file_formatter.write within the legacy code, I use a disabling_log_file method to temporarily "mute" the @log_file_formatter within a block. This commit is intended as a stopgap to restore compatibility with with SSHKit @ master until more serious refactoring can be done.
|
I think it's possible to do this by calling One small thing to note is that the Hope this helps! |
|
Closed in favor of #19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robd I based this off of #13 and then added the minimum amount of changes to make the code compatible with SSHKit master. The important changes are in 24343d6.
Do you agree this is a good stopgap solution?