Run assorted e2e test scenarios in separate CI jobs (#109)

Instead of manually writing different test cases for different combinations of answers (Vite, RSpec, etc.), parameterize those options via environment variables. This lets us run various scenarios via CI in parallel across a matrix of jobs. This gives us better test coverage and should run faster due to parallel execution.
mattbrictson · Sep 16, 2024 · 051e6b5 · 051e6b5
1 parent 7aeafbc
commit 051e6b5
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,9 +28,27 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - run: bundle exec rake test
-  integration_test:
-    name: "Test / E2E"
+  integration-test:
+    name: "Test / E2E / Rails ${{ matrix.version }} / ${{ matrix.frontend }} frontend / ${{ matrix.test-framework }}"
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - version: current
+            frontend: default
+            test-framework: minitest
+          - version: current
+            frontend: default
+            test-framework: rspec
+          - version: current
+            frontend: vite
+            test-framework: minitest
+          - version: current
+            frontend: vite
+            test-framework: rspec
+          - version: edge
+            frontend: default
+            test-framework: minitest
     needs: [rubocop, test]
     steps:
       - uses: actions/checkout@v4
@@ -41,4 +59,21 @@ jobs:
       - run: git config --global user.name 'github-actions[bot]'
       - run: git config --global user.email 'github-actions[bot]@users.noreply.github.com'
       - run: gem install --no-document railties --version "~> 7.2.0"
-      - run: bundle exec rake test:e2e
+      - name: rake test:e2e
+        env:
+          NEXTGEN_VERSION: ${{ matrix.version }}
+          NEXTGEN_FRONTEND: ${{ matrix.frontend }}
+          NEXTGEN_TEST_FRAMEWORK: ${{ matrix.test-framework }}
+        run: bundle exec rake test:e2e
+  test-all:
+    name: "Test / All"
+    runs-on: ubuntu-latest
+    needs: [test, integration-test]
+    if: always()
+    steps:
+      - name: All tests ok
+        if: ${{ !(contains(needs.*.result, 'failure')) }}
+        run: exit 0
+      - name: Some tests failed
+        if: ${{ contains(needs.*.result, 'failure') }}
+        run: exit 1
diff --git a/test/e2e/nextgen_e2e_test.rb b/test/e2e/nextgen_e2e_test.rb
@@ -6,16 +6,29 @@
 require "securerandom"
 
 class NextgenE2ETest < Minitest::Test
+  VERSION_KEYSTROKES = {
+    current: "",
+    edge: "\e[B"
+  }.freeze
+
+  FRONTEND_KEYSTROKES = {
+    default: "",
+    vite: "\e[B\e[B"
+  }.freeze
+
+  TEST_FRAMEWORK_KEYSTROKES = {
+    minitest: "",
+    rspec: "\e[B"
+  }.freeze
+
   def test_nextgen_generates_rails_app
-    assert_bundle_exec_nextgen_create(stdin_data: "\n\n\n\n\n\n\n\n\n\n\n\u0001\n\n")
-  end
+    version_keys = VERSION_KEYSTROKES.fetch((ENV["NEXTGEN_VERSION"] || "current").to_sym)
+    frontend_keys = FRONTEND_KEYSTROKES.fetch((ENV["NEXTGEN_FRONTEND"] || "default").to_sym)
+    test_framework_keys = TEST_FRAMEWORK_KEYSTROKES.fetch((ENV["NEXTGEN_TEST_FRAMEWORK"] || "minitest").to_sym)
 
-  def test_nextgen_generates_vite_rails_app
-    assert_bundle_exec_nextgen_create(stdin_data: "\n\n\n\n\e[B\e[B\n\n\n\n\n\u0001\n\n")
-  end
+    stdin_data = "\n" + version_keys + "\n\n\n" + frontend_keys + "\n\n\n\n\n" + test_framework_keys + "\n\n\u0001\n\n"
 
-  def test_nextgen_generates_rspec_rails_app
-    assert_bundle_exec_nextgen_create(stdin_data: "\n\n\n\n\n\n\n\n\n\e[B\n\n\u0001\n\n")
+    assert_bundle_exec_nextgen_create(stdin_data:)
   end
 
   private