Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redshift subnet group terminator support #162

Merged
merged 2 commits into from
Sep 20, 2021
Merged

Redshift subnet group terminator support #162

merged 2 commits into from
Sep 20, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 16, 2021

jillr
jillr reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need 'arn:aws:redshift:{{ aws_region }}:{{ aws_account_id }}:subnetgroup:*' as a resource.

Everything else lgtm as tested with community.aws/pull/719

@tremble tremble force-pushed the resdhift_subnet_group branch from e39599c to 7417858 Compare September 17, 2021 05:27
@tremble tremble force-pushed the resdhift_subnet_group branch from 7417858 to 6a06d53 Compare September 17, 2021 05:28
jillr
jillr approved these changes Sep 20, 2021
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jillr jillr merged commit e5b82d2 into mattclay:master Sep 20, 2021
@tremble tremble deleted the resdhift_subnet_group branch February 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremble @jillr