Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use config chain-id before using default #525

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: use config chain-id before using default #525

merged 2 commits into from
Jan 9, 2025

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jan 9, 2025

What 💻

  • Use config chain_id before using TEST_NODE_NETWORK_ID.

Why ✋

  • --chain-id wasn't being respected

Evidence 📷

image

@nbaztec nbaztec requested a review from a team as a code owner January 9, 2025 12:47
@nbaztec nbaztec mentioned this pull request Jan 9, 2025
Merged
@popzxc popzxc merged commit fbf14a3 into matter-labs:main Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbaztec @popzxc