-
Notifications
You must be signed in to change notification settings - Fork 85
Fix license issue of the third party code #9
base: main
Are you sure you want to change the base?
Conversation
In case there is some third party files that was included in this project, you must include a short version of the license on the header of the file if it is unable to add |
Hey @chiro-hiro, thank you for taking the time to think about and suggest improvements! Our attributions right now follow a strict reading of the license requirements. We’re currently surveying best practices in the space and beyond it in order to find the best approach that threads the needle between (1) giving thanks and attributions; (2) keeping our project as easy as possible to fork and encouraging collaboration and building on top of our ideas; and (3) respecting existing norms and best practices. In that spirit, we’d love to learn from you as well — what are you basing these practices on? |
Hi @shahar4, that's great to hear that you guys start working on it and take it seriously. I've spent years to learn about open source and open source license. In this case, the main issue isn't about license compatibility since both projects were licensed under neither My conclusion was based on https://www.apache.org/legal/apply-license.html and https://opensource.org/license/mit/. Let's see what were wrong. 1. You shouldn't remove the license files You might notice that every license have two forms a full-length and a short-form (e.g APL2.0 Header). The full-length license used to on the root folder and it will cover the rest of the project in many cases. If there is some files with the different license, then the license in the short-form can include in the header of the code. Both APL2.0 and MIT allowed you to copy/update the code but you must include the license and copyright. MIT
APL2.0 - 4.a, 4.b, 4.c, 4.d
2. Keep the copyright notice Both MIT and APL2.0 allows you to add your copyright section but remove the old records are prohibited. You could check two news licenses in this PR for more detail and check the NOTICE file. The APL2.0 is more strict for the copyright, you're only hold the copyright for the changes you made. MIT
APL2.0 - 4
|
Hey @chiro-hiro, Thank you so much for your taking the time to add context to your feedback! As I mentioned above, we're reviewing best practices and so this is very helpful! We will not merge this PR as the way we applied attribution & licenses does adhere to the requirements of the licenses, but will absolutely learn from your suggested patterns. When we come up with our strategy we’ll share it and invite some more feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trust.
This pull request update some license files to make sure that this repo follows a good practice of open source code of conduct.
I removed this part from the license files (
LICENSE-MIT
andLICENSE-APACHE
) since these notices isn't a part of the license and you shouldn't modify the license.I removed
ThirdPartyNotices.txt
since you shouldn't include two original licenses in one file.I add
NOTICE
files and license on the top level of the given folder to make sure that it will track any copyright changes.