Skip to content

Commit

Permalink
fix(prover-logging): tasks_allowed_to_finish set to true for 1 off jo…
Browse files Browse the repository at this point in the history
…bs (#227)

# What ❔

# tasks_allowed_to_finish set to true for 1 off jobs

## Why ❔

* with `tasks_allowed_to_finish` set to true results in incorrect error
logging when no jobs are present

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [* ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ *] Code has been formatted via `zk fmt` and `zk lint`.
  • Loading branch information
akash-chandrakar authored Oct 17, 2023
1 parent a19256e commit 0fac66f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion prover/proof_fri_compressor/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ async fn main() -> anyhow::Result<()> {
];

let graceful_shutdown = None::<futures::future::Ready<()>>;
let tasks_allowed_to_finish = false;
let tasks_allowed_to_finish = true;
tokio::select! {
_ = wait_for_tasks(tasks, None, graceful_shutdown, tasks_allowed_to_finish) => {},
_ = stop_signal_receiver => {
Expand Down
2 changes: 1 addition & 1 deletion prover/witness_generator/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ async fn main() -> anyhow::Result<()> {

let mut stop_signal_receiver = get_stop_signal_receiver();
let graceful_shutdown = None::<futures::future::Ready<()>>;
let tasks_allowed_to_finish = false;
let tasks_allowed_to_finish = true;
tokio::select! {
_ = wait_for_tasks(tasks, None, graceful_shutdown, tasks_allowed_to_finish) => {},
_ = stop_signal_receiver.next() => {
Expand Down

0 comments on commit 0fac66f

Please sign in to comment.