ci: Fixed zk-environment workflow typos and npm issues. (#833)

## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `cargo spellcheck
--cfg=./spellcheck/era.cfg --code 1`.

.github/workflows/zk-environment-publish.yml

@@ -23,7 +23,7 @@ jobs:
     outputs:
       zk_environment: ${{ steps.changed-files-yaml.outputs.zk_env_any_changed }}
       zk_environment_cuda_11_8: ${{ steps.changed-files-yaml.outputs.zk_env_cuda_11_8_any_changed }}
-      zk_environment_cuda_12: ${{ steps.changed-files-yaml.outputs.zk_env_cuda_12_any_changed }}
+      zk_environment_cuda_12_0: ${{ steps.changed-files-yaml.outputs.zk_env_cuda_12_any_changed }}
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
@@ -37,13 +37,13 @@ jobs:
           files_yaml: |
             zk_env:
               - docker/zk-environment/Dockerfile
-              - .github/workflows/zk-environment.publish.yml
+              - .github/workflows/zk-environment-publish.yml
             zk_env_cuda_11_8:
               - docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile
-              - .github/workflows/zk-environment.publish.yml
+              - .github/workflows/zk-environment-publish.yml
             zk_env_cuda_12:
               - docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile
-              - .github/workflows/zk-environment.publish.yml
+              - .github/workflows/zk-environment-publish.yml
 
   get_short_sha:
     if: needs.changed_files.outputs.zk_environment == 'true'

docker/zk-environment/20.04_amd64_cuda_11_8.Dockerfile

@@ -50,10 +50,13 @@ RUN apt update; apt install -y docker-ce-cli
 # Configurate git to fetch submodules correctly (https://stackoverflow.com/questions/38378914/how-to-fix-git-error-rpc-failed-curl-56-gnutls)
 RUN git config --global http.postBuffer 1048576000
 
-# Install node and yarn
-RUN wget -c -O - https://deb.nodesource.com/setup_18.x | bash -
-RUN apt-get install -y nodejs
-RUN npm install -g yarn
+# Install Node and yarn
+ENV NODE_MAJOR=18
+RUN mkdir -p /etc/apt/keyrings && \
+    wget -c -O - https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
+    echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
+    apt-get update && apt-get install nodejs -y && \
+    npm install -g yarn
 
 # Install Rust and required cargo packages
 ENV RUSTUP_HOME=/usr/local/rustup \

docker/zk-environment/20.04_amd64_cuda_12_0.Dockerfile

@@ -49,9 +49,12 @@ RUN apt update; apt install -y docker-ce-cli
 RUN git config --global http.postBuffer 1048576000
 
 # Install node and yarn
-RUN wget -c -O - https://deb.nodesource.com/setup_18.x | bash -
-RUN apt-get install -y nodejs
-RUN npm install -g yarn
+ENV NODE_MAJOR=18
+RUN mkdir -p /etc/apt/keyrings && \
+    wget -c -O - https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
+    echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
+    apt-get update && apt-get install nodejs -y && \
+    npm install -g yarn
 
 # Install Rust and required cargo packages
 ENV RUSTUP_HOME=/usr/local/rustup \

docker/zk-environment/Dockerfile

@@ -83,7 +83,7 @@ ENV NODE_MAJOR=18
 RUN mkdir -p /etc/apt/keyrings && \
     wget -c -O - https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
     echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
-    apt-get update && apt-get install nodejs -y && \
+    apt-get update && apt-get install nodejs npm -y && \
     npm install -g yarn
 
 # Install Rust and required cargo packages